Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMTLibInherited class probably not needed #10

Open
Miepee opened this issue Nov 29, 2023 · 2 comments
Open

UMTLibInherited class probably not needed #10

Miepee opened this issue Nov 29, 2023 · 2 comments

Comments

@Miepee
Copy link

Miepee commented Nov 29, 2023

https://github.com/VladiStep/UndertaleRusInstaller_GUI/blob/main/UndertaleRusInstallerGUI/UTMTLibInherited.cs

This file is AFAIK unnecessary.

@VladiStep
Copy link
Owner

It is necessary for code import, and also it contains message box overloads/methods.

@Miepee
Copy link
Author

Miepee commented Nov 30, 2023

but you're not providing an actual .csx scripts. you have the whole install written as your code, which means you should be free to not make it inheriting from IScriptInterface, and instead just split the functionality.
i.e. into a code import class and a message box helper class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants