From 6a5f55a35c33b3c544eeefacadc6cbe3f3776015 Mon Sep 17 00:00:00 2001 From: Ben Henning Date: Tue, 18 Jun 2024 20:07:11 -0700 Subject: [PATCH] Fix #5428: Remove kotlin-android-extensions plugin (#5429) ## Explanation Fixes #5428 This PR removes all occurrences of the kotlin-android-extensions plugin. See the issue for specifics, but it seems the plugin wasn't actually being used anywhere (due to it never being enabled in Bazel and the old code that depended on it being removed years ago), so this only affects Gradle builds & tests. It should be a mostly benign change. ## Essential Checklist - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only This isn't expected to impact the user experience at all. It's possible the final build changes a bit, but that should be innocuous since the plugin isn't actually being used for anything. --- app/build.gradle | 1 - data/build.gradle | 1 - domain/build.gradle | 1 - testing/build.gradle | 1 - utility/build.gradle | 1 - 5 files changed, 5 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 34a996bfce2..05fb3d39c25 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -2,7 +2,6 @@ apply plugin: 'com.android.application' apply plugin: 'com.google.firebase.crashlytics' apply plugin: 'com.google.gms.google-services' apply plugin: 'kotlin-android' -apply plugin: 'kotlin-android-extensions' apply plugin: 'kotlin-kapt' android { diff --git a/data/build.gradle b/data/build.gradle index 8c0c911d167..103cea56f3b 100644 --- a/data/build.gradle +++ b/data/build.gradle @@ -1,6 +1,5 @@ apply plugin: 'com.android.library' apply plugin: 'kotlin-android' -apply plugin: 'kotlin-android-extensions' apply plugin: 'kotlin-kapt' android { diff --git a/domain/build.gradle b/domain/build.gradle index 0ab591327ef..0d35db61ce2 100644 --- a/domain/build.gradle +++ b/domain/build.gradle @@ -1,6 +1,5 @@ apply plugin: 'com.android.library' apply plugin: 'kotlin-android' -apply plugin: 'kotlin-android-extensions' apply plugin: 'kotlin-kapt' android { diff --git a/testing/build.gradle b/testing/build.gradle index 7add13a2b3d..26f050e48ef 100644 --- a/testing/build.gradle +++ b/testing/build.gradle @@ -1,6 +1,5 @@ apply plugin: 'com.android.library' apply plugin: 'kotlin-android' -apply plugin: 'kotlin-android-extensions' apply plugin: 'kotlin-kapt' android { diff --git a/utility/build.gradle b/utility/build.gradle index cc39995dbd0..487c60f8b71 100644 --- a/utility/build.gradle +++ b/utility/build.gradle @@ -1,6 +1,5 @@ apply plugin: 'com.android.library' apply plugin: 'kotlin-android' -apply plugin: 'kotlin-android-extensions' apply plugin: 'kotlin-kapt' android {