-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap fetchVariableQuery over to SOLR from NEO4J #1400
Comments
Hi @Robbie1977 , I have been debugging this issue with the branches you created. I'm debugging using the SOLR query instead of Neo4J, getting 400 responses from the SOLR server. https://solr.VirtualFlyBrain.org/solr/vfb_json/select This is the query parameters sent to the SOLR server, do they look good to you: The 400 returned error is this , finds the query invalid with 'fl' as a key:
|
@jrmartin there isn't anything wrong with the query but you are missing quotes on the q:, you should also only request 1 row, and pf shouldn't be called. The simplest that will work is: |
@jrmartin the response bugs me as not sure the sub 'json' should be there as I get responces like: {
"responseHeader":{
"status":0,
"QTime":0,
"params":{
"q":"VFB_00002990",
"defType":"edismax",
"indent":"true",
"qf":"id",
"fl":"term_info",
"q.op":"OR",
"rows":"1",
"_":"1675434400746"}},
"response":{"numFound":1,"start":0,"numFoundExact":true,"docs":[
{ with parameters in the top level under params |
Thanks for checking @Robbie1977 , the query works now. Still working out the JSON processing part. |
Made progress and it looks most things are loading with SOLR query now. Further testing next two days. ARG geppettoDatasourceRelease=addingSOLR |
The swap works fully now. Only branches with changes made are: ARG geppettoDatasourceRelease=addingSOLR |
We need to move fetchVariableQuery via neo4J (https://github.com/VirtualFlyBrain/geppetto-vfb/blob/solr-queries/model/vfb.xmi#L625) over to SOLR (started here: https://github.com/VirtualFlyBrain/geppetto-vfb/blob/solr-queries/model/vfb.xmi#L917).
This requires a new SOLR datasource started here: https://github.com/openworm/org.geppetto.datasources/tree/addingSOLR
New uk bundle with boiler plate copy of the NEO4J processing step for solr added:
https://github.com/VirtualFlyBrain/uk.ac.vfb.geppetto/blob/addSOLRcache/src/main/java/uk/ac/vfb/geppetto/VFBProcessTermInfoCachedJson.java
This will need a step to convert the JSON string into something the be passed as per the neo4j results which is also a string but the reponses are formatted differently. This is as far as I got as couldn't get any reponse from debug so assume the datasource is failing to process the SOLR call correctly but little feedback on the server end.
The partially started model is here (new query added with the start of processing): https://github.com/VirtualFlyBrain/geppetto-vfb/tree/solr-queries
Note the branches used here:
https://github.com/VirtualFlyBrain/geppetto-vfb/blob/solr-queries/Dockerfile#L11
The text was updated successfully, but these errors were encountered: