Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryChecker not consistent #1361

Open
Robbie1977 opened this issue Aug 20, 2022 · 2 comments
Open

QueryChecker not consistent #1361

Robbie1977 opened this issue Aug 20, 2022 · 2 comments
Assignees
Labels

Comments

@Robbie1977
Copy link
Contributor

Stacking query constraints is working fine in the query builder as seen below (both NBLAST and NeuronBridge queries appear) but in the list returned in the term info derived from query checker (https://github.com/VirtualFlyBrain/uk.ac.vfb.geppetto/blob/download/src/main/java/uk/ac/vfb/geppetto/VFBProcessTermInfoJson.java#L1576 -> https://github.com/openworm/org.geppetto.core/blob/VFBv2.1.1/src/main/java/org/geppetto/core/datasources/QueryChecker.java) the second row of constraints doesn't seem to get checked. Need to check what https://github.com/openworm/org.geppetto.model/blob/VFBv2.1.0.1/src/main/java/org/geppetto/model/datasources/QueryMatchingCriteria.java#L27 is returning.

image

I've created a dev-query-issue branch to keep the issue for testing as going to split out the queries into two to hopefully resolve for release but this problem is affecting other queries so a fix is urgent.

@jrmartin
Copy link
Contributor

@Robbie1977 I have been debugging this today. Is the expected behavior that the queries we see in the drop down of the Query component are also shown on the Term Info?

For the example posted on this card, for VFB_001013ce.
I see these (screenshot below and same ones as in your screenshot), using branch 'dev-query-issue'.
Is the only thing missing on the Term Info the query for NBlast?
' Neurons with similar morphology to part of JRC_LH1518_Brain_2019_20150227_41_F1_20x [NBLAST mean score]
Filter Results'

image

jrmartin added a commit that referenced this issue Sep 3, 2022
@jrmartin
Copy link
Contributor

jrmartin commented Sep 7, 2022

@ddelpiano @Robbie1977 A fix for this was made on org.geppetto.core openworm/org.geppetto.core#187. The branch feature/186 has the fix, tested locally and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants