Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix short_form discrepancies #66

Open
matentzn opened this issue Jul 28, 2020 · 4 comments
Open

Fix short_form discrepancies #66

matentzn opened this issue Jul 28, 2020 · 4 comments
Assignees

Comments

@matentzn
Copy link

Some of the entities in KB have non-derivable short_forms, that is: KB uses a short_form that cannot be derived again by pdb. Now this may or may not be a problem, but at least I wanted to point it out (I noticed that some datasets in p2.pdb have different short_forms than pdb1).

MATCH (n:Entity) WHERE not n.iri =~ ('.*' + n.short_form) RETURN n.iri, n.short_form LIMIT 250

Results in 40 entities with such discrepancies. To fix this, you would have to:

  1. Fix the site: issue in general (URLs don't always have short forms)
  2. Fix some of the entities manually (for example datasets), by changing the short form to the respective IRI fragment.

Example:

"http://virtualflybrain.org/data/Aso_Rubin_2016" | "AsoRubin2016"
@Robbie1977
Copy link
Contributor

Robbie1977 commented Oct 8, 2020

@dosumis This is also affecting DOI pub nodes:

KB: short_form:doi_10_1101_376384 
PDB.p2: short_form:376384 

Note: Irrespective of if the short form uses new '__ = /' format or not. We should standardise whatever we do.

@dosumis
Copy link
Member

dosumis commented Oct 8, 2020

I wonder why there's truncation on _. The only characters that should be used for short_form derivation are / & #.

@matentzn
Copy link
Author

matentzn commented Oct 8, 2020

Remeber the iri has a / there - that is probably why.

@dosumis
Copy link
Member

dosumis commented Oct 8, 2020

You beat me to it. Just realised that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants