Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Append doesn't always append #160

Open
MrSamoDude opened this issue Mar 5, 2024 · 5 comments
Open

[Bug] Append doesn't always append #160

MrSamoDude opened this issue Mar 5, 2024 · 5 comments

Comments

@MrSamoDude
Copy link

The append feature doesn't aways work, this occurs on both the iPhone and Mac versions of Obsidian. If I've recently opened Obsidian and the destination note, the append feature appears to work successfully. If I've not already got Obsidian open or recently visited the destination note, the append feature will successfully open Obsidian and open the respective note, but doesn't always append the required text to the end of the note. It feels like there's some kinds of timeout kicking in before the append function can complete or it's trying to append before the note has fully opened. If I launch the same URI a 2nd time the data is successfully appended.

I'm calling the URI from Apple Shortcuts. An example of the URI I'm using:
obsidian://advanced-uri?vault=vault_name&filepath=Bookmarks/site_name.md&data=data&mode=append

The destination note is currently over 100 lines long if that has any impact.

Obsidian v1.5.8
Advanced URI v1.40.0
Sonoma 14.3.1 or iOS v17.3.1

Thanks

@MrSamoDude MrSamoDude changed the title Bug Report - Append doesn't always append [Bug] Append doesn't always append Mar 5, 2024
@tch123
Copy link

tch123 commented Apr 2, 2024

mode=prepend has the same problem
obsidian://advanced-uri?vault=vault_name&daily=true&data=1111&mode=prepend

  • Fails when document is not created
  • Fails when document has been created without any content
  • Execution is successful when the document has been created and has content

Obsidian v1.5.8
Advanced URI v1.40.0
Windows 10
Android 13

@bcohen44
Copy link

bcohen44 commented Apr 8, 2024

I am noticing that append from iOS shortcuts never works, or stopped working at some point

@Vinzent03
Copy link
Owner

I could reproduce the prepend issue with an empty file, which is now fixed in the new version. But other than everything worked fine on linux, android and iOS. @bcohen44 please share the not working uri.

@bcohen44
Copy link

obsidian://advanced-uri?vault=Brian_Obsidian_Vault&daily=true&data=foo%20bar&mode=append
When I send this on Chrome on Windows, it works fine.
on iOS, I get a "File already exists"error

@Liquidmantis
Copy link

In my case, the lost append when the note doesn't exist, the issue stems from race conditions created by other extensions. The primary culprit for me is Templater. Disabling its file create hook, where it will apply the template on note create, appears to have fixed my uninitialized note append for me, albeit in limited testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants