Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Position Options for Popups #3

Open
Vidit-Kushwaha opened this issue Jul 3, 2024 · 0 comments
Open

Add New Position Options for Popups #3

Vidit-Kushwaha opened this issue Jul 3, 2024 · 0 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@Vidit-Kushwaha
Copy link
Owner

Description:

Currently, react-popupify supports only the center position for popups. To enhance flexibility and usability, we would like to add new position options. The following positions are requested:

  • top-right
  • top-left
  • bottom-right
  • bottom-left
  • bottom-center

Acceptance Criteria:

  1. New Position Options:

    • Implement the following positions:
      • top-right: Popup positioned at the top-right corner of the viewport.
      • top-left: Popup positioned at the top-left corner of the viewport.
      • bottom-right: Popup positioned at the bottom-right corner of the viewport.
      • bottom-left: Popup positioned at the bottom-left corner of the viewport.
      • bottom-center: Popup positioned at the bottom-center of the viewport.
  2. Configuration:

    • Ensure that these new positions can be set via props or configuration options in the popup component.
  3. Documentation:

    • Update the documentation to include examples of how to use the new position options.
  4. Testing:

    • Add or update tests to cover the new position options.

Additional Notes:

If there are any design or implementation considerations to take into account for the new positions, please include them in the pull request description.

@Vidit-Kushwaha Vidit-Kushwaha added the enhancement New feature or request label Jul 3, 2024
@Vidit-Kushwaha Vidit-Kushwaha self-assigned this Jul 3, 2024
@Vidit-Kushwaha Vidit-Kushwaha removed their assignment Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant