Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Timeout with stream_context before 4 #117

Open
worker24h opened this issue Nov 22, 2024 · 11 comments
Open

Read Timeout with stream_context before 4 #117

worker24h opened this issue Nov 22, 2024 · 11 comments

Comments

@worker24h
Copy link
Contributor

worker24h commented Nov 22, 2024

image

as above, read timeout (default: 30s) by virctorialogs web console

@hagen1778 @dmitryk-dk @Loori-R I am developing show context of logs pannel #41

Cloud you see it ?

@dmitryk-dk
Copy link
Contributor

Hi @worker24h ! Need to check your question and why it happens. I suppose this is VMLogs limitation

@worker24h
Copy link
Contributor Author

worker24h commented Nov 22, 2024

Hi @worker24h ! Need to check your question and why it happens. I suppose this is VMLogs limitation

I think syntax is correct,as follow, it's timeout too. The may be a bug?
image

@dmitryk-dk @hagen1778

@dmitryk-dk
Copy link
Contributor

dmitryk-dk commented Nov 22, 2024

Hi @worker24h ! Need to check your question and why it happens. I suppose this is VMLogs limitation

I think syntax is correct,as follow, it's timeout too. The may be a bug? image

@dmitryk-dk @hagen1778

I think there can be solutions.

  1. Could you check the query in the developer mode network tab.? Is there timeout query param present?
The maximum query execution time is limited by -search.maxQueryDuration command-line flag value. This limit can be overridden to smaller values on a per-query basis by passing the needed timeout via timeout query arg. For example, the following command limits query execution time to 4.2 seconds:

Could you increase the -search.maxQueryDuration flag to 90s and check if it helps?

@worker24h
Copy link
Contributor Author

worker24h commented Nov 22, 2024

Hi @worker24h ! Need to check your question and why it happens. I suppose this is VMLogs limitation

I think syntax is correct,as follow, it's timeout too. The may be a bug? image

@dmitryk-dk @hagen1778

I think there can be solutions.

  1. Could you check the query in the developer mode network tab.? Is there timeout query param present?

The maximum query execution time is limited by -search.maxQueryDuration command-line flag value. This limit can be overridden to smaller values on a per-query basis by passing the needed timeout via timeout query arg. For example, the following command limits query execution time to 4.2 seconds:

Could you increase the -search.maxQueryDuration flag to 90s and check if it helps?

I know it cloud be changed for timeout period.
But I search data in latest 5min and limit 50 , it should response quickly. May be bug of victorialogs backend ?
Do you think it doesn't timeout , too?

@dmitryk-dk
Copy link
Contributor

Hi @worker24h ! Need to check your question and why it happens. I suppose this is VMLogs limitation

I think syntax is correct,as follow, it's timeout too. The may be a bug? image

@dmitryk-dk @hagen1778

I think there can be solutions.

  1. Could you check the query in the developer mode network tab.? Is there timeout query param present?

The maximum query execution time is limited by -search.maxQueryDuration command-line flag value. This limit can be overridden to smaller values on a per-query basis by passing the needed timeout via timeout query arg. For example, the following command limits query execution time to 4.2 seconds:

Could you increase the -search.maxQueryDuration flag to 90s and check if it helps?

I know it cloud be changed for timeout period. But I search data in latest 5min and limit 50 , it should response quickly. Do you think it doesn't timeout , too?

It looks like a bug in the VMLogs. If you can develop the feature while the bug will be fixed it would be cool.
Also you can create the ticket in the https://github.com/VictoriaMetrics/VictoriaMetrics repository with a description

@hagen1778
Copy link
Contributor

Hey @worker24h! This seems suspicious. Are you sure VictoriaLogs is up&running and isn't overwhelmed with other service that is making requests?

@worker24h
Copy link
Contributor Author

worker24h commented Nov 22, 2024

Hey @worker24h! This seems suspicious. Are you sure VictoriaLogs is up&running and isn't overwhelmed with other service that is making requests?

Yes If I remove stream_context before 4, then get response quickly. So I think this is a bug with stream_context @hagen1778

@hagen1778
Copy link
Contributor

I see. Please, open a bug report then.

@worker24h
Copy link
Contributor Author

I see. Please, open a bug report then.

I want try to fixed it and interest it, but I doesn't read source code never, so do you offer some articles or debugger method? Thanks

@worker24h
Copy link
Contributor Author

worker24h commented Nov 23, 2024

VictoriaMetrics/VictoriaMetrics#7637
I create a new issue for this BUG.

@hagen1778 @dmitryk-dk

@dmitryk-dk
Copy link
Contributor

I see. Please, open a bug report then.

I want try to fixed it and interest it, but I doesn't read source code never, so do you offer some articles or debugger method? Thanks

Hi! You can check the source code starts from the ProcessQueryRequest
https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/app/vlselect/main.go#L194
https://github.com/VictoriaMetrics/VictoriaMetrics/blob/6c6e469bfb8ad84f4d72412a015f7b7292cd713f/lib/logstorage/pipe_stream_context.go#L669

and you can go up from this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants