Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart vmagent shards concurrently if replicaCount > 1 #1248

Open
xiaozongyang opened this issue Feb 25, 2025 · 0 comments
Open

Restart vmagent shards concurrently if replicaCount > 1 #1248

xiaozongyang opened this issue Feb 25, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@xiaozongyang
Copy link

Backgroud

Now we have 12 vmagent shards and there are 2 replicas of each shard.
When we apply changes to the crd VMAgent, the operator restarts the pods of VMAgent one by one. For each pod it will consume about 2 minutes to trigger the pod restart and wait it ready. I'll spend about 50 minutes to watch the operation process. So I'm wondering that we could modify the restart process to speed up the operation process.

What I want

Since we have 2 replicas for each shard, we could restart one replica of every shard. The full steps will be

  1. we restart replica 0 of every shard
  2. wait all replica 0 get ready
  3. restart replica 1 of every shard
  4. wait all replicas 1 get ready

If we change the deloy process to this way, the upgrading process should complete more quickly.

Futhermore, we can upgrade restart every shard concurrently if shardCount won't change.

cc @f41gh7

@f41gh7 f41gh7 added the enhancement New feature or request label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants