Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl restart doesn't work with Deployments and Statefulsets managed by operator #1215

Closed
f41gh7 opened this issue Jan 13, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@f41gh7
Copy link
Collaborator

f41gh7 commented Jan 13, 2025

kubectl restart command uses special annotation - kubectl.kubernetes.io/restartedAt, which added to the spec.template.metadata:

https://kubernetes.io/docs/reference/kubectl/generated/kubectl_rollout/kubectl_rollout_restart/

After recent changes to the annotations merge introduced after #1171

Operator ignores any changes to spec.template.metadata changed by 3-rd party clients.

It'd be great to keep those annotations.

@f41gh7 f41gh7 added the bug Something isn't working label Jan 13, 2025
f41gh7 added a commit that referenced this issue Jan 21, 2025
Annotations to the Deployment and Statefulset `templace.spec.metadata` could be added by 3rd party tools.
Like `kubectl` rollout restart command. Operator must keep it as is, since it's not managed by it.
 This commit adds `mergeAnnotations` function to it, in order to distingush managed by operator and 3rd party
annotations.

 Related issue:
#1215

Signed-off-by: f41gh7 <[email protected]>
@f41gh7 f41gh7 added the waiting for release The change was merged to upstream, but wasn't released yet. label Jan 21, 2025
@f41gh7
Copy link
Collaborator Author

f41gh7 commented Jan 22, 2025

Issue was fixed at v0.52.0 release

@f41gh7 f41gh7 closed this as completed Jan 22, 2025
@f41gh7 f41gh7 removed the waiting for release The change was merged to upstream, but wasn't released yet. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant