Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConsulSDConfig support for filter field #1196

Closed
spirkaa opened this issue Dec 19, 2024 · 1 comment
Closed

ConsulSDConfig support for filter field #1196

spirkaa opened this issue Dec 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@spirkaa
Copy link

spirkaa commented Dec 19, 2024

In docs https://docs.victoriametrics.com/sd_configs/#consul_sd_configs mentioned, that vmagent supports filter field, but operator don't - operator.victoriametrics.com/v1beta1, Kind=VMScrapeConfig): .spec.consulSDConfigs[0].filter: field not declared in schema.

Can this support be added?
@f41gh7 f41gh7 added the bug Something isn't working label Dec 19, 2024
f41gh7 added a commit that referenced this issue Dec 19, 2024
@f41gh7
api/vmscrapeconfig: add filter field to consulSDConfigs
f431edf 
This commit adds `filter` field to the `consulSDConfigs`. This setting exists only at
VictoriaMetrics implementation of consul service discovery. Prometheus doesn't support it.

Related issue:
#1196

Signed-off-by: f41gh7 <[email protected]>
@f41gh7
Copy link
Collaborator

f41gh7 commented Dec 19, 2024

The issue was fixed at v0.51.1 release

@f41gh7 f41gh7 closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spirkaa @f41gh7