Inconsistent logging format

[emilbillberg]

Hi,

I am running victoria metrics operator v0.50.0; and I have noticed the log format can be a bit inconsistent.

I have noticed these log fields:

• namespace
• controller
• desiredVersion
• podMustRecreate
• sts.name
• vmcluster
• vmalert
• vmalertmanager
• rules
• secret_for
• len
• ' len ' (contains spaces)
• 'map names'
• 'invalid rules'
• 'invalid configs'
• 'desired version'

Some of them perhaps should stay, some of them should most likely be merged with the msg field instead. The spaces should also be removed from the keys as log collectors usually add a _ or . and it can be a bit weird.

I would expect msg, level and ts to exist as well as a few other consistent log fields which helps to understand the context of the log.

[f41gh7]

The issue was fixed at v0.51.1 release

It removes extra context from structured logs, like secret_for. And leaves only useful for filtering fields, such as:

• component names: vmcluster, vmagent, etc...
• controller.CRDName
• namespace and parent_namespace

All previously added fields moved into message field value.

It'd be great to refactor logger later and use format string, instead of fmt.Sprintf workaround.