Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing target label container after adding discoveryRole: endpointslices to VMServiceScrape #1187

Closed
xiaozongyang opened this issue Dec 12, 2024 · 3 comments

Comments

@xiaozongyang
Copy link

I have a VMServiceScrape with default discoveryRole for a dcgm-exporter endpoint. Since its size exceed 1K, I change its discoveryRole to endpointslices. I found that the laebl exported_container new metric disappeared after upgrade. When I diff the config in vmagent, I found folloowing diff between two versions.

My VMOperator version is v0.42.4.

# default discoveryRole
source_labels:
__meta_kubernetes_pod_name
target_label: pod
source_labels:
__meta_kubernetes_pod_container_name
target_label: container
source_labels:
__meta_kubernetes_namespace
target_label: namespace
# discoveryRole: endpointslices
source_labels:
__meta_kubernetes_pod_name
target_label: pod
source_labels:
__meta_kubernetes_namespace
target_label: namespace
@f41gh7
Copy link
Collaborator

f41gh7 commented Dec 12, 2024

Hello, issue was fixed a v0.50.0 version of operator:
https://github.com/VictoriaMetrics/operator/blob/master/docs/CHANGELOG.md#v0500---22-nov-2024

 add missing container labels to the metrics discovered with VMServiceScrape for endpointslices discovery role.

@xiaozongyang
Copy link
Author

@f41gh7 Thanks for you reply! This issue will be closed. By the way, I just read source code about that of version v0.49.1, it seems that this bug has been fixed.

PPS I can't find git tag v0.50.0, is this verison released already?

@f41gh7
Copy link
Collaborator

f41gh7 commented Dec 12, 2024

@f41gh7 Thanks for you reply! This issue will be closed. By the way, I just read source code about that of version v0.49.1, it seems that this bug has been fixed.

PPS I can't find git tag v0.50.0, is this verison released already?

Yes, it was released, https://github.com/VictoriaMetrics/operator/tree/v0.50.0

If you browse git locally, try to update local state with remote branch. The following command could help git fetch origin --tags .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants