-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build error on VS 2022 #117
base: master
Are you sure you want to change the base?
Conversation
I'm also done with the Command Line feature in the process selection list(#116), but it will be pushed as a separated PR. |
OK, then I guess you did not intend to include it in this PR. What about the wine submodule? I don't have the newer commit. Was it an intentional change? If so, please submit a PR to that repository first. CI (AppVeyor) needs to be green before anything can be merged, so ensuring that CI builds continue working is going to have to be a part of this. |
Thank you for your rapid response.
I will try to do the missing work tomorrow.
…On Tue, Aug 15, 2023, 22:37 Vladimir Panteleev ***@***.***> wrote:
I'm also done with the Command Line feature in the process selection list(
#116 <#116>), but it will
be pushed as a separated PR.
OK, then I guess you did not intend to include it in this PR.
What about the wine submodule? I don't have the newer commit. Was it an
intentional change? If so, please submit a PR to that repository first.
CI (AppVeyor) needs to be green before anything can be merged, so ensuring
that CI builds continue working is going to have to be a part of this.
—
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPH4SUNPMBPWW7EEA3RFCTXVOCUHANCNFSM6AAAAAA3Q5RU74>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hi, I have implemented the feature #116 which show command line and window title in the process list. But I met some problems to make a PR: I'm using Visual Studio 2022 to build this project, after I open this project, it let me upgrade all vcproj files to 2022, otherwise there are build errors:
I tried to download and install the Visual Studio 2010 build tools, but it is already outdated, MS doesn't provide it. I can upgrade submodules which are belong to VerySleepy, but wxWidgets is not a part of VerySleep project, if I upgrade them to VS 2022 projects, I don't know how to issue a PR to them. Even if I only fix this build error, I also met this problem. |
Sorry, I don't know how to help you here, except for two things:
|
I can't make any progress on this issue due to this blocking issue, anyone can help me? Here is some more information, FYI: |
Maybe I don't make any changes on the VS version, disregard my local build, just make the CI happy? |
Many projects meet those issues, since VS build-system tries real hard to be incompatible, but you shouldn't let that discourage you:
Or even without CMake:
Internet has many unofficial backups. |
Fix #115