Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build master in VS22 Release x64 #103

Open
lefterise opened this issue May 18, 2022 · 5 comments · Fixed by #104
Open

Can't build master in VS22 Release x64 #103

lefterise opened this issue May 18, 2022 · 5 comments · Fixed by #104

Comments

@lefterise
Copy link

Compiler complains that
profiler.cpp lines 115, 139, 145
context.Eip is a 32bit value being cast to a 64bit pointer.

Except.h lines 41, 49
can not construct a char string by passing iterator to wchar string

@lefterise
Copy link
Author

lefterise commented May 18, 2022

I hackishly got master branch to compile but i get a message box saying Seek error on file '...\Temp\A35D.tmp' (error 131: An attempt was made to move the file pointer before the beginning of the file.)

I think it's caused by database.cpp line 171 zip.OpenEntry(*entries["minidump.dmp"])
I opened A35D.tmp with 7-zip and it does not contain that file. I assume that file is optional, however since
"minidump.dmp" does not exist in the entries map i assume it tries to de-reference a pointer to null. At that point I would have expected an access violation however it seems it continues working until it reaches zipstrm.cpp of wxWidgets and tries to QuietSeek to offset -1

@CyberShadow
Copy link
Member

CyberShadow commented May 18, 2022

I hackishly got master branch to compile but i get a message box saying Seek error on file '...\Temp\A35D.tmp' (error 131: An attempt was made to move the file pointer before the beginning of the file.)

Might have been introduced in #98, CC @mojomojomojo

@mojomojomojo
Copy link
Contributor

There's a fix for that problem in #99.

@CyberShadow
Copy link
Member

If you would like to submit your changes needed to get the project to build with your compiler as a pull request, I'll do my best to review and merge it.

@lefterise
Copy link
Author

lefterise commented May 18, 2022

I pull request #105 submitted.

-It removes the definition of applyHacks from the x64 build. (The method is only called from x86, compiler under x64 complains that a 32bit value is used for a 64bit pointer)
-It changes the way wstring is converted to string. It uses widechartomultibyte windows API
-It fixes a memory leak in database.cpp. GetNextEntry() gives us ownership of a wxZipEntry so we are responsible to delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants