Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

House Keeping: ui* fuction naming has no convention #9

Open
ElSkunkito opened this issue Nov 14, 2015 · 3 comments
Open

House Keeping: ui* fuction naming has no convention #9

ElSkunkito opened this issue Nov 14, 2015 · 3 comments
Assignees

Comments

@ElSkunkito
Copy link
Collaborator

setVisbility should be uiSetVisibility

the uiSelect* and uiSetSelect * functions should all be uiSelectBlah functions

uuiSetLabel should be uiLabelSet

a convention should be chosen
the convention should then be applied, with hilarious result in red error text..
Liberal, but careful use of search and replace will be needed.

@ElSkunkito
Copy link
Collaborator Author

Fuzz, can you assign this to your self for the first part,
answer what convention is good.

I am thinking
funtion ui(Controltype)(Action)(Optional refinement)
uiLabelSetEmpty
ui????Set(Something), Applies to both BUTTONss and LABELs, but not INPUT type="text"
contains the text overlaid on a button, or in a label, i do not like Text as it implies text box.
uiTextSetEmpty
uiSelectAddItem
uiSelectAddItemExplicit
uiSelectAddItemEmpty
uiElementHide
uiElementShow

and such

@ElSkunkito ElSkunkito changed the title ui* fuction naming has no convention House Keeping: ui* fuction naming has no convention Nov 15, 2015
@tucotuco tucotuco self-assigned this Nov 26, 2015
@tucotuco
Copy link
Member

To me, a good convention is uiTargetAction. Is that sufficient to do the refactoring?

@tucotuco tucotuco assigned ElSkunkito and unassigned tucotuco Nov 29, 2015
@ElSkunkito
Copy link
Collaborator Author

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants