Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.1 ,the checkout is not working after applying the fix #14

Open
MaalyALkaraki opened this issue Sep 4, 2020 · 8 comments
Open

Comments

@MaalyALkaraki
Copy link

first i would thank you for this fix , I applyed the fix for a Magento 2.1.7 site but the checkout is not working , the log has no reference for the fix ,they are using php7.1,

@HirokazuNishi
Copy link
Contributor

Unfortunately, I didn't test it against Magento2.1.x, because Magento2.1.x was already EOL. You should update it to 2.3 or 2.4 first.

@MaalyALkaraki
Copy link
Author

we apply it to magento 2.3.2 and unfortunately we have the same issue .

@HirokazuNishi
Copy link
Contributor

Could you share me more details? How to reproduce? Any screen shots? JS error logs or PHP logs?

@MaalyALkaraki
Copy link
Author

-after applying the fix ,it was stopping the add to cart from working, it will just keep spinning ,
-the php error is :
PHP Fatal error: Uncaught Error: Call to a member function getStoreId() on null
in /home/wwwsite /public_html/vendor/magento/module-quote/Model/Quote/Payment.php:286.
-on js error

@HirokazuNishi
Copy link
Contributor

Please share me more.

  • How was your browser's cookie?
  • What browser did you use?

We use latest version for M2.3.x customers, but no one reported such case :(

@MaalyALkaraki
Copy link
Author

  1. The browser's cookies it test them when it was all on default mode for same-site cookie
  2. I used the latest update for chrome browser .
    And i tried it on a Magento 2.3.4 :
    in this case the checkout wat working but the orders was not passed to the admin side , and the same site cookies did not turned to none in the browser after applying the fix .
    we got this php error
    m

@HirokazuNishi
Copy link
Contributor

Does your website run full HTTPS? SameSite=None is only allowed with Secure flag.

@MaalyALkaraki
Copy link
Author

yes it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants