Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fails because of simple mistake #127

Open
diegoacs0 opened this issue Jul 22, 2024 · 4 comments
Open

Update Fails because of simple mistake #127

diegoacs0 opened this issue Jul 22, 2024 · 4 comments

Comments

@diegoacs0
Copy link

Operating system

Windows 11

YouTube Music Desktop App Version

0.12.16

Bug description

When you try to update by clicking the update button in the app, it doesn`t update or replace the files correctly with the installer because the app is still open.
You guys should turn the app off and so then the installer could be executed to replace the files with the new update.

Steps to reproduce

Click the update button and wait to see that it is still open at taskbar.

Relevant log output

No response

@Venipa
Copy link
Owner

Venipa commented Jul 28, 2024

It should already close the app once the new app version has been downloaded
I mean it's the electron-updater's library doing that, I'll update it soon maybe that's just it
Thanks 👍

@ryanwills720
Copy link

I noticed the same issue as diegoacs0. I closed the taskbar version as the installer popped up, and it did indeed install correctly. I then had to close out, unpin from the taskbar and reopen a new/2nd icon to the taskbar.

Previously, it would just keep installing the update and prompting for a new update on a reopen.

@Venipa
Copy link
Owner

Venipa commented Sep 18, 2024

Hmm I noticed it happening between large changes that included updating the electron updater package, it maybe that the package location has changed in-between

@somethinlike
Copy link

This thing still doesn't update properly, it's extremely annoying, going to be uninstalling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants