Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write descriptions for lexicon categories #4637

Open
TheRealWormbo opened this issue May 8, 2024 · 0 comments
Open

Write descriptions for lexicon categories #4637

TheRealWormbo opened this issue May 8, 2024 · 0 comments
Labels
easy Small, clearly-scoped bug suitable for a first contribution or Hacktoberfest help-wanted Patches are wanted for this issue. Please drop us a note on Discord as well. misc-todo Cleanup and other non-coding tasks

Comments

@TheRealWormbo
Copy link
Collaborator

Mod Loader

Both Fabric and Forge (I confirm that I have tested both loaders and will specify both loader versions below)

Minecraft Version

1.20.1

Botania version

443

Modloader version

(any)

Modpack info

No response

The latest.log file

(n/a)

Issue description

Currently Botania reuses the category titles to also fill the description page for each category. Ideally these should be replaced with slightly longer descriptions of what to expect from the category, probably roughly half a page long as most.

Below is an example of the issue: Instead of saying "Mana Manipulation" twice, a more useful text for this category page would be nice.
Screenshot of the "Mana Manipulation" category page

Steps to reproduce

No response

Other information

To add a description, the description property in each category page definition (JSON files under Xplat/src/main/resources/assets/botania/patchouli_books/lexicon/en_us/categories) needs to be set to a different translation key (e.g. something like "botania.category.description."), and that same key needs to be added to the en_us.json translation file.

The intention is somewhat related to the now unused entry tag lines, but descriptions can be slightly more verbose than that.

@TheRealWormbo TheRealWormbo added misc-todo Cleanup and other non-coding tasks help-wanted Patches are wanted for this issue. Please drop us a note on Discord as well. easy Small, clearly-scoped bug suitable for a first contribution or Hacktoberfest labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Small, clearly-scoped bug suitable for a first contribution or Hacktoberfest help-wanted Patches are wanted for this issue. Please drop us a note on Discord as well. misc-todo Cleanup and other non-coding tasks
Development

No branches or pull requests

1 participant