Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify/choose branch on sub-folder repositories. #2570

Open
kcrtr opened this issue Jan 7, 2022 · 3 comments
Open

Ability to specify/choose branch on sub-folder repositories. #2570

kcrtr opened this issue Jan 7, 2022 · 3 comments

Comments

@kcrtr
Copy link

kcrtr commented Jan 7, 2022

I'd like to be able to specify the branch for sub-folder git repos.

For example:

my-site:
    repo: https://github.com/Varying-Vagrant-Vagrants/custom-site-template.git
    hosts:
      - mysite-test
    folders:
      public_html/wp-content/:
        git:
          repo: https://github.com/Automattic/vip-go-skeleton.git
          branch: develop
          overwrite_on_clone: true

While I could do this manually I feel as though it defeats the purpose of the feature especially since the top level repo can have a branch selected.

@welcome
Copy link

welcome bot commented Jan 7, 2022

Thanks for opening your first issue here! Be sure to follow the issue template and include your OS/Vagrant/VVV versions! Don't forget you can get support in the VVV slack at https://varyingvagrantvagrants.org/docs/en-US/slack/

VVV
Join the VVV Slack Workspace

@tomjn
Copy link
Member

tomjn commented Jan 7, 2022

Agreed, this code will need to change:

https://github.com/Varying-Vagrant-Vagrants/VVV/blob/develop/provision/provision-site.sh#L331-L343

And

https://github.com/Varying-Vagrant-Vagrants/VVV/blob/develop/provision/provision-site.sh#L411-L426

GitHub
An open source Vagrant configuration for developing with WordPress - VVV/provision-site.sh at develop · Varying-Vagrant-Vagrants/VVV
GitHub
An open source Vagrant configuration for developing with WordPress - VVV/provision-site.sh at develop · Varying-Vagrant-Vagrants/VVV

@kcrtr
Copy link
Author

kcrtr commented Jan 10, 2022

Thank you!

@tomjn tomjn modified the milestones: 3.9, 3.10 Apr 8, 2022
@tomjn tomjn modified the milestones: 3.10, 3.11 Sep 10, 2022
@tomjn tomjn modified the milestones: 3.11, 3.13 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants