Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency issues with React 17 #85

Open
PerryRylance opened this issue Oct 17, 2021 · 1 comment
Open

Dependency issues with React 17 #85

PerryRylance opened this issue Oct 17, 2021 · 1 comment

Comments

@PerryRylance
Copy link

PerryRylance commented Oct 17, 2021

Describe the bug
Looks like this package has peer dependency [email protected], I'm using 17.0.2.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new project with npx create-react-app
  2. npm install react-preloaders
  3. npm run
  4. Import and add any preloader eg <Cube/> to your app's root
  5. Visit localhost:3000

Expected behavior
The app starts with the preloader visible.

Observed behaviour

1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app

Screenshots
image

Desktop (please complete the following information):
n/a

Smartphone (please complete the following information):
n/a

Additional context
Apologies if I'm missing something here.

@xAl3xFx
Copy link

xAl3xFx commented Oct 20, 2021

Hello I have forked the project and fixed that issue several months ago.
https://www.npmjs.com/package/react-preloaders2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants