-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for sites without a pathPrefix
#20
Comments
@Vagr9K
Could this validator be disabled? Apparently only changing the parser in SEO component is not a good idea. For example, somewhere else (in Disqus), it also uses urljoin to get the url which also leads to |
Apparently In any case, you can either use an empty string or Some additional validations to prevent incorrectly generated URLs were added. Thanks for the report! |
The boilerplate code doesn't allow an empty
pathPrefix
indata/siteConfig.js
but allows a/
which will be regarded as "" (empty) somewhere and, there are also some code which will convert "" (empty)pathPrefix
to a/
.These incompatibilities lead to URLs like
https://org.github.io//test-url
(note the double slash) in SEO and social share links.The text was updated successfully, but these errors were encountered: