From 481ae5fe49e9950767e7f2c88930dfe843451b18 Mon Sep 17 00:00:00 2001 From: Adam Dangoor Date: Wed, 20 May 2026 08:26:11 +0100 Subject: [PATCH] Revert __dict__.get and __getattribute__ to getattr with inline disables. Keep pylint bad-builtin enforcement in config; suppress only at the call sites that need dynamic attribute access. Co-authored-by: Cursor --- src/mock_vws/_requests_mock_server/decorators.py | 5 +++-- src/mock_vws/_respx_mock_server/decorators.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mock_vws/_requests_mock_server/decorators.py b/src/mock_vws/_requests_mock_server/decorators.py index 5b0244c81..87536e106 100644 --- a/src/mock_vws/_requests_mock_server/decorators.py +++ b/src/mock_vws/_requests_mock_server/decorators.py @@ -160,7 +160,8 @@ def wrapped( # req_kwargs is added dynamically by the responses # library onto PreparedRequest objects - it is not # in the requests type stubs. - req_kwargs: dict[str, Any] = request.__dict__.get( + req_kwargs: dict[str, Any] = getattr( # pylint: disable=bad-builtin + request, "req_kwargs", {}, ) @@ -224,7 +225,7 @@ def __enter__(self) -> Self: compiled_url_pattern = re.compile(pattern=url_pattern) for http_method in route.http_methods: - original_callback = object.__getattribute__( + original_callback = getattr( # pylint: disable=bad-builtin api, route.route_name, ) diff --git a/src/mock_vws/_respx_mock_server/decorators.py b/src/mock_vws/_respx_mock_server/decorators.py index 92ed0c9e0..c9a59e6c8 100644 --- a/src/mock_vws/_respx_mock_server/decorators.py +++ b/src/mock_vws/_respx_mock_server/decorators.py @@ -161,7 +161,7 @@ def start_respx_router( compiled_url_pattern = re.compile(pattern=url_pattern) for http_method in route.http_methods: - original_callback = object.__getattribute__( + original_callback = getattr( # pylint: disable=bad-builtin api, route.route_name, )