Skip to content

Refactor: Integrate PciDevice with new Driver Interface #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 50 commits into
base: master
Choose a base branch
from
Draft

Refactor: Integrate PciDevice with new Driver Interface #816

wants to merge 50 commits into from

Conversation

@IgnoreWarnings
Copy link
Collaborator

@IgnoreWarnings IgnoreWarnings commented Aug 23, 2024

No description provided.

@IgnoreWarnings IgnoreWarnings added enhancement New feature or request refactor labels Aug 23, 2024
@IgnoreWarnings IgnoreWarnings force-pushed the pci-integration branch 6 times, most recently from 10ceffc to a595511 Compare August 26, 2024 10:36
@IgnoreWarnings IgnoreWarnings mentioned this pull request Aug 30, 2024
Merged
@IgnoreWarnings IgnoreWarnings force-pushed the pci-integration branch 2 times, most recently from 5afc947 to a4f130e Compare September 4, 2024 16:20
@IgnoreWarnings
Copy link
Collaborator Author

IgnoreWarnings commented Sep 6, 2024

Waiting for #808

@IgnoreWarnings IgnoreWarnings force-pushed the pci-integration branch 2 times, most recently from 624c571 to 8b583c2 Compare October 11, 2024 13:19
@IgnoreWarnings
add device interface
babe80f 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
add driver interface
d312e37 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
add generic driver
adeaa9d 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
add utils
dca4d4c 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
add platform device
9d6b81b 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
add IpDevice
d65910a 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
add new classes to cmake
abc56a9 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
fix generic driver header
9b1524f 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
cmake move drivers to linux section
10e6aee 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
remove duplicate public
ce8aa3f 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
delete default comnstructor
2357122 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
formatting
0c270c5 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
use filename()
46065f3 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
cleanup code
6e7c9c6 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
Refactor: move device utility functions to villas util
80d7942 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
rename GenericDriver to LinuxDriver
ca2715d 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
rename generic_driver to linux_driver
e945a9e 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
update driver comment
51eaea3 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
initial commit
fadb14c 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
Driver Interface
ae3ab18 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
fix broken includes
3659225 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
remove unused code
0400f19 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
rename Platform driver to GenericDriver
1f9d7d5 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
inherit from device interface
b229d7c 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
implement driver()
ec3da8d 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
implement iommu_group
4772060 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
implement name
2bfccaa 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
removed unused code
56b2d69 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
format
cac2e89 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
implement override_path
d054b9a 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
implement path
8e21811 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
format
97d35e4 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
implement probe
04f8c92 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
remove semicolon
6f6fe52 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
add include
795a565 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
adjust to new interface
09eac47 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
update namespace
45f3533 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
adjust utils to refactor
2b98171 
Signed-off-by: Pascal Bauer <[email protected]>
@IgnoreWarnings
apply driver refactor
a41e30e 
Signed-off-by: Pascal Bauer <[email protected]>
@stv0g
Copy link
Contributor

stv0g commented Jan 28, 2025

#808 is merged. Do you plan on merging this?

@IgnoreWarnings
Copy link
Collaborator Author

IgnoreWarnings commented Jan 29, 2025

#808 is merged. Do you plan on merging this?

This has no priority and will be revisioned when i am done with platform integration.

@stv0g
Copy link
Contributor

stv0g commented Nov 5, 2025

Hi @IgnoreWarnings, @n-eiling,

I am wondering, do you still forsee progress on this? I am uncertain how Niklas's departure from ACS might have affected this work?

Should we keep this PR, or close it?

@IgnoreWarnings
Copy link
Collaborator Author

IgnoreWarnings commented Nov 5, 2025

Hi @IgnoreWarnings, @n-eiling,

I am wondering, do you still forsee progress on this? I am uncertain how Niklas's departure from ACS might have affected this work?

Should we keep this PR, or close it?

Hi, I am currently woking on another project (at acs) and wont progress this work.
This branch is an integration/refactor of the old codebase to the driver interface i developed. It doesnt provide any new features or fixes and will therefore not be completed in forseable future.

Niklas and I completed the merge of all relevant features before I moved to another project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n-eiling n-eiling Awaiting requested review from n-eiling n-eiling will be requested when the pull request is marked ready for review n-eiling is a code owner

@stv0g stv0g Awaiting requested review from stv0g stv0g will be requested when the pull request is marked ready for review stv0g is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request node::fpga refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IgnoreWarnings @stv0g