Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FATAL] v0.83.1 breaks client #357

Open
jakobjung10 opened this issue Dec 18, 2024 · 6 comments
Open

[FATAL] v0.83.1 breaks client #357

jakobjung10 opened this issue Dec 18, 2024 · 6 comments

Comments

@jakobjung10
Copy link

Version 0.83.1 breaks the editor-clients in VSCode (possibly other editors, too).

Affected extensions:

  • VHDL LS
  • VHDL by HGB

image

BR,
Jakob

@Xcodo
Copy link
Contributor

Xcodo commented Dec 18, 2024

I can also see the same issue.

It looks like the source is the packaging of the files. There is a sub-folder missing in the zip file. Comparing with the last release:

├───vhdl_ls-x86_64-pc-windows-msvc_0.83.0
│   └───vhdl_ls-x86_64-pc-windows-msvc
│       ├───bin
│       └───vhdl_libraries
│           ├───ieee2008
│           ├───std
│           ├───synopsys
│           └───vital2000
├───vhdl_ls-x86_64-pc-windows-msvc_0.83.1
│   ├───bin
│   └───vhdl_libraries
│       ├───ieee2008
│       ├───std
│       ├───synopsys
│       └───vital2000

@ALL-SPACE-Jukka
Copy link

ALL-SPACE-Jukka commented Dec 18, 2024

I believe that I've figured out the cause of this, as explained in my comment on the VS Code extension repo VHDL-LS/rust_hdl_vscode#103 (comment). TL;DR the problem is that the path of the executable inside the latest release's .zip is missing a directory in its path. The executable still exists on your machine, it's just in the wrong place.

Until this is fixed, you can work around the problem (in VS code at least) by switching your VHDL LS extension's "language server" setting from embedded to user to use a user-defined path, and you then change the "language server user path" setting to the path shown in your error message, but with the vhdl_ls-x86_64... directory removed.

My config is working currently and is as follows:

    "vhdlls.languageServer": "user",
    "vhdlls.languageServerUserPath": "<path>/.vscode/extensions/hbohlin.vhdl-ls-0.7.0/server/vhdl_ls/0.83.1/bin/vhdl_ls",

(I'm on Linux, so you'll have to change the forward slashes to backslashes on Windows).

Once the problem is corrected, you will need to switch the "language server" setting back to embedded.

@Xcodo
Copy link
Contributor

Xcodo commented Dec 18, 2024

I have used the same fix and this is also working on Windows:

"vhdlls.languageServerUserPath": "<path>\\.vscode\\extensions\\hbohlin.vhdl-ls-0.7.0\\server\\vhdl_ls\\0.83.1\\bin\\vhdl_ls.exe",
"vhdlls.languageServer": "user"

@Schottkyc137
Copy link
Contributor

I think this is fixed now. Would it be possible for someone to verify?

@JHertz5
Copy link

JHertz5 commented Dec 18, 2024

@Schottkyc137 I've done a test by deleting the 0.83.1 directory to force VHDL LS to re-download the executable, and it is working for me 🥳 Thanks very much!

@Xcodo
Copy link
Contributor

Xcodo commented Dec 19, 2024

Also for me. But clients which have already downloaded 0.83.1 will still fail until a newer version is available. I suggest releasing a 0.83.2 version to force clients to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants