Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Imputing Zeroes: refactor R util function #24

Open
d-callan opened this issue Aug 21, 2023 · 0 comments
Open

Map Imputing Zeroes: refactor R util function #24

d-callan opened this issue Aug 21, 2023 · 0 comments

Comments

@d-callan
Copy link
Member

i did a thing here #19 .. and then i got tired and ran out of time and wasnt sure what the future would hold besides and thought, i have to call it somewhere. so im filing this ticket to keep track of some things that i maybe could have done but didnt, and might have to do yet sometime in the future. those things are:

  1. make a MegastudyPlot or similar class that has slots for a Megastudy and a VariableMetadata object. move some validation from the imputing method to this class validator fxn. (this could ultimately lead to a reworking of the plot.data API..)
  2. moving the helper fxns inside the imputing method to stand on their own and have explicit tests
  3. make sure the imputing method never removes columns, or make it so that it always removed columns it doesnt need. (it shouldnt hurt anything that it does remove them, but its done inconsistently)..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant