Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map - bubble size endpoint is not taking into account overlay variable "little filter" effects #734

Open
bobular opened this issue Nov 27, 2023 · 1 comment
Labels
front or back end needs discussion on where it should be fixed

Comments

@bobular
Copy link
Member

bobular commented Nov 27, 2023

It looks like a similar issue to #733 and others maybe.

Analysis/diagnosis after the examples...

Site: qa.vectorbase.org
Study: megastudy
Bubble marker variable: enzyme activity ratio (mean population reference)

The ONLY data for this variable is in Singapore.
The markers are all way smaller than the bubble size legend which says they could go up to 5000
image

Even when zoomed out to just one marker, it is still nowhere near the 5000 max size shown in the legend:
image

With a "catch all" filter for the enzyme activity variable, the sizing is now sensible:
image
image

I think the max bubble size maxSizeValue: 4542 is the largest marker for the Insecticide resistance assay output entity when it is NOT filtered for "has_any_value_for enzyme activity ratio (mean population reference)"

Do we want to solve this on the front end (send an extra catch-all filter for the overlay variable) or on the back end?

Bear in mind with categorical variables, the front end would have to add a non-trivial filter if the user has checked values in the marker config. However, we will likely be adding front end logic to convert little filters into actual filters anyway, see VEuPathDB/web-monorepo#548 and VEuPathDB/web-monorepo#596

@bobular bobular transferred this issue from VEuPathDB/web-monorepo Nov 27, 2023
@bobular bobular added the front or back end needs discussion on where it should be fixed label Nov 27, 2023
@bobular
Copy link
Member Author

bobular commented Feb 1, 2024

I will have a look at this after the little filter refactor is merged and decide how to tackle/prioritise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front or back end needs discussion on where it should be fixed
Projects
None yet
Development

No branches or pull requests

1 participant