Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide means to automatically adapt the (territory) extent to a loaded set of 3DTiles tilesets #397

Open
EricBoix opened this issue Jul 19, 2022 · 3 comments
Labels
enhancement itowns This issue required changes in itowns priority-medium

Comments

@EricBoix
Copy link
Contributor

EricBoix commented Jul 19, 2022

Related issue: #146

The need

When realizing 3DTiles based demos, the territory extent (the portion of the territory whose map is displayed) is usually specified manually (e.g. this py3dTilers demo).
Such an extent depends on the considered set of 3DTiles tilesets and is usually manually extracted (through a lengthy trial and error process).
Because (3DTiles) tilesets encode their own extent, the demo extent could be automatically extracted and computed out of the considered tileset set.

@valentinMachado
Copy link
Contributor

Today that's not really possible because a 3DTilesLayer needs a view as param constructor and a view needs an extent as param constructor. So in order to create a 3DTiles layer we have to fix before the extent, the problem belongs to itowns.

@valentinMachado valentinMachado added the itowns This issue required changes in itowns label Apr 25, 2023
@EricBoix EricBoix changed the title Provide meands to automatically adapt the (territory) extent to a loaded set of 3DTiles tilesets Provide means to automatically adapt the (territory) extent to a loaded set of 3DTiles tilesets May 5, 2023
@EricBoix
Copy link
Contributor Author

EricBoix commented May 5, 2023

@valentinMachado Couldn't we automatically extract the bounding of the considered Tileset, consider it's 2d extension to make it an extent PRIOR to constructing the view and only then the 3DTilesLayer ?

@valentinMachado
Copy link
Contributor

Yes we could but that's not very elegant to request the tileset.json since C3DTilesLayer is going to do it. The problem here is that a C3DTilesLayer should be able to be instanciated without a View. It's also quite weird to write something like:

const layer = new Layer(..., view);
view.add(layer)

see

Iam not sure why this has been implemented this way but I've discussed of it with @jailln and it should be refacto in itowns at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement itowns This issue required changes in itowns priority-medium
Projects
None yet
Development

No branches or pull requests

3 participants