Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problème de création des individus de géométrie lors de la conversion de CityGML en RDF #44

Open
fati-assat opened this issue Jul 28, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@fati-assat
Copy link

j'ai utilise la commande suivante
python XML2RDF.py --output output --format ttl C:/Users/cami/Downloads/FZK-HausUTM.gml citygml_3_mappings.json https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/appearance https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/bridge https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/building https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/cityfurniture https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/cityobjectgroup https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/construction https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/core https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/dynamizer https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/generics https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/landuse https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/pointcloud https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/relief https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/transportation https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/tunnel https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/vegetation https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/versioning https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/waterbody https://www.w3.org/2009/08/skos-reference/skos.rdf http://www.opengis.net/ont/geosparql# https://schemas.opengis.net/gml/3.2.1/gml_32_geometries.rdf https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/Alignments/CityGML3-GeoSPARQL https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/Alignments/CityGML3-ISO19136 https://def.isotc211.org/ontologies/iso19136/2007/Feature.rdf https://def.isotc211.org/ontologies/iso19107/2003/CoordinateGeometry.rdf

mais pour les resultats je trouve ceci pas de geometrie
image

@DiegoVinasco DiegoVinasco self-assigned this Jul 29, 2024
@DiegoVinasco
Copy link
Contributor

Bonjour,

Merci d'avoir soumis cette issue.

Ce problème devrait être corrigé maintenant (ici).

Une vérification des déclarations de namespaces redondant cassait la génération des geo:GMLLiteral dans certains fichiers GML. Cependant, comme la plupart des fichiers GML n'ont pas ce problème, la vérification a été enlevée.

Je l'ai testé avec nos fichiers de test CityGML 2.0 et 3.0 et la géométrie semble être générée correctement.

Pourriez-vou intégrer les dernières modifications, les tester sur votre fichier GML et nous faire savoir si cela a fonctionné ?


Hello, thanks for submitting this issue.

This should be fixed now (here).

A check for redundant namespace declarations was breaking geometry literal generation in certain GML files. However, since most GML files don't have this problem, the check was removed.

I tested it with our CityGML 2.0 and 3.0 test files and the geometry seems to be generating correctly.

Could you please pull in the latest changes, test it on your GML file, and let us know if it worked?

@DiegoVinasco DiegoVinasco added the bug Something isn't working label Jul 29, 2024
@fati-assat
Copy link
Author

fati-assat commented Jul 29, 2024 via email

@fati-assat
Copy link
Author

fati-assat commented Aug 1, 2024 via email

@DiegoVinasco
Copy link
Contributor

DiegoVinasco commented Aug 23, 2024

Hello @fati-assat ,

Could you please send me the GML file you are trying to triple? I would like to test it on my end please.

@fati-assat
Copy link
Author

fati-assat commented Aug 24, 2024 via email

@DiegoVinasco
Copy link
Contributor

Hello @fati-assat,

I ran XML2RDF with the following command and was able to produce gml literal values

python XML2RDF.py -v --format ttl ../test-data/GML/FZK-HausUTM.gml citygml_3_mappings.json https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/appearance https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/bridge https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/building https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/cityfurniture https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/cityobjectgroup https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/construction https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/core https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/dynamizer https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/generics https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/landuse https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/pointcloud https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/relief https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/transportation https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/tunnel https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/vegetation https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/versioning https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/CityGML/3.0/waterbody https://www.w3.org/2009/08/skos-reference/skos.rdf http://www.opengis.net/ont/geosparql# https://schemas.opengis.net/gml/3.2.1/gml_32_geometries.rdf https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/Alignments/CityGML3-GeoSPARQL https://dataset-dl.liris.cnrs.fr/rdf-owl-urban-data-ontologies/Ontologies/Alignments/CityGML3-ISO19136 https://def.isotc211.org/ontologies/iso19136/2007/Feature.rdf https://def.isotc211.org/ontologies/iso19107/2003/CoordinateGeometry.rdf

For example, these triples were generated for the GML solid with id id_051b6ebb-4fa6-4a26-b381-5b9608fdd1b4-0:

data:id_051b6ebb-4fa6-4a26-b381-5b9608fdd1b4-0 a gmlowl:Solid,
        owl:NamedIndividual ;
    geo:asGML "<gml:Solid xmlns:gml='http://www.opengis.net/gml' gml:id='id_051b6ebb-4fa6-4a26-b381-5b9608fdd1b4-0' srsName='EPSG:25832' srsDimension='3'>\\t\\t\\t\\t\\t\\t\\t<gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t<gml:Shell>\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:Surface gml:id='id_051b6ebb-4fa6-4a26-b381-5b9608fdd1b4-1'>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:posList>457841.80000666046 5439086.510154003 110 457841.80000666046 5439082.800154003 110 457841.80000666046 5439082.800154003 112.5 457841.80000666046 5439086.510154003 112.5 457841.80000666046 5439086.510154003 110</gml:posList>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:Surface>\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:Surface gml:id='id_051b6ebb-4fa6-4a26-b381-5b9608fdd1b4-2'>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:posList>457841.80000666046 5439086.510154003 110 457845.30000666046 5439086.510154003 110 457846.1950066605 5439086.510154003 110 457846.1950066605 5439082.800154003 110 457841.80000666046 5439082.800154003 110 457841.80000666046 5439086.510154003 110</gml:posList>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:Surface>\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:Surface gml:id='id_051b6ebb-4fa6-4a26-b381-5b9608fdd1b4-3'>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:posList>457841.80000666046 5439082.800154003 110 457846.1950066605 5439082.800154003 110 457846.1950066605 5439082.800154003 112.5 457841.80000666046 5439082.800154003 112.5 457841.80000666046 5439082.800154003 110</gml:posList>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:Surface>\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:Surface gml:id='id_051b6ebb-4fa6-4a26-b381-5b9608fdd1b4-4'>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:posList>457841.80000666046 5439086.510154003 112.5 457841.80000666046 5439082.800154003 112.5 457846.1950066605 5439082.800154003 112.5 457846.1950066605 5439086.510154003 112.5 457845.30000666046 5439086.510154003 112.5 457841.80000666046 5439086.510154003 112.5</gml:posList>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:Surface>\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:Surface gml:id='id_051b6ebb-4fa6-4a26-b381-5b9608fdd1b4-5'>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:posList>457845.30000666046 5439086.510154003 110 457841.80000666046 5439086.510154003 110 457841.80000666046 5439086.510154003 112.5 457845.30000666046 5439086.510154003 112.5 457845.30000666046 5439086.510154003 110</gml:posList>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:Surface>\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:Surface gml:id='id_051b6ebb-4fa6-4a26-b381-5b9608fdd1b4-6'>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:posList>457846.1950066605 5439086.510154003 110 457845.30000666046 5439086.510154003 110 457845.30000666046 5439086.510154003 112.5 457846.1950066605 5439086.510154003 112.5 457846.1950066605 5439086.510154003 110</gml:posList>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:Surface>\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:Surface gml:id='id_051b6ebb-4fa6-4a26-b381-5b9608fdd1b4-7'>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t<gml:posList>457846.1950066605 5439082.800154003 110 457846.1950066605 5439086.510154003 110 457846.1950066605 5439086.510154003 112.5 457846.1950066605 5439082.800154003 112.5 457846.1950066605 5439082.800154003 110</gml:posList>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:LinearRing>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:exterior>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:PolygonPatch>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:patches>\\t\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:Surface>\\t\\t\\t\\t\\t\\t\\t\\t\\t</gml:surfaceMember>\\t\\t\\t\\t\\t\\t\\t\\t</gml:Shell>\\t\\t\\t\\t\\t\\t\\t</gml:exterior>\\t\\t\\t\\t\\t\\t</gml:Solid>\\t\\t\\t\\t\\t"^^geo:gmlLiteral ;
    geo:coordinateDimension "EPSG:25832" ;
    geo:spatialDimension "3" ;
    skos:prefLabel "id_051b6ebb-4fa6-4a26-b381-5b9608fdd1b4-0" .

Are you sure you are using the latest patch of the transformer?
If not, please pull the latest changes and try again.

If so, could you send me the following information, please:

  • Operating system and version
  • Python version

Thanks in advance!

@fati-assat
Copy link
Author

fati-assat commented Aug 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants