Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs understanding. Runtime dependencies. #36

Open
einspunktnull opened this issue Jun 30, 2023 · 2 comments · May be fixed by #43
Open

Docs understanding. Runtime dependencies. #36

einspunktnull opened this issue Jun 30, 2023 · 2 comments · May be fixed by #43

Comments

@einspunktnull
Copy link

einspunktnull commented Jun 30, 2023

he guys, thx a lot for this great tool.

i have created a package with pyproject.toml, i took ur's and changed executable path within the [tool.poetry.scripts] section. I can colcon build this package and colcon_poetry_ros.dependencies.install installs my_package and it's deps within the install/my_package/local/lib/python3.10/dist-packages dir. but when i run executable with ros2 run my_package my_executable i get runtime error ModuleNotFoundError: No module named 'my_package'. it seems the installed dist-packages are not part of the python path. i thought it will be added automatically or did i misunderstand this?

@velovix
Copy link
Member

velovix commented Jun 30, 2023

You understood correctly, but I believe this tool has trouble with newer versions of Pip. It's a bug that I need to look into. Would you mind trying again with this version of Pip and letting me know if the behavior changes?

pip3 install --upgrade pip==21.2.4

@einspunktnull
Copy link
Author

einspunktnull commented Jun 30, 2023

yes with pip 21.2.4 it indeed works.
and yes this adds the pythonpath.sh to the install/my_package/share/my_package/hook dir.
these files are not created with the newer versions pip versions 22.0.2 and 23.1.2, i initially used.

@velovix velovix linked a pull request Nov 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants