Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify effects on test task #14

Open
velovix opened this issue Dec 20, 2021 · 0 comments
Open

Clarify effects on test task #14

velovix opened this issue Dec 20, 2021 · 0 comments

Comments

@velovix
Copy link
Member

velovix commented Dec 20, 2021

Right now, the test task defined in this extension is a thin wrapper around the Python test task defined by colcon-core, but with PyTest forced on. However, looking at the code, there's no reason why the oddly named setup.py testing mode wouldn't work. It just appears to run tests using unittest.

The only thing that will definitely not work is colcon-core's automatic testing mode detection. It uses dependencies specified in the user's setup.py to figure out whether to use PyTest or unittest automatically. It looks like the code is written with fallbacks in case that information is not available, but it's worth investigating if we can do some auto-detection of our own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant