Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Accessories #138

Open
theDerpu opened this issue Jan 23, 2025 · 5 comments
Open

Support Accessories #138

theDerpu opened this issue Jan 23, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@theDerpu
Copy link

theDerpu commented Jan 23, 2025

#107 (comment)


similar to this issue, support for the accessories mod's slot for it in the same way would be great 🙏

(Ps, for accessories to have trinkets slots (and the spyglass one) you need the following, incase it's needed:

  • accessories
  • trinket compat layer for accessories
  • trinkets
  • spyglass trinket slot

)

Not sure what versions accessories goes up to but 1.20.1 support would be great

@EnnuiL
Copy link
Contributor

EnnuiL commented Jan 23, 2025

Considering that Trinkets has been dead since 1.21.1 (although even that port was verging towards death), I'll consider supporting Accessories as it apparently will become Trinkets' (and Curios') de-facto replacement in the future;

While this should be easy to pull off? I've been busy with uni, so I'll likely tackle this on February

@EnnuiL EnnuiL added the enhancement New feature or request label Jan 23, 2025
@EnnuiL EnnuiL changed the title Compat for accessories with spyglass slot mod Support Accessories Jan 25, 2025
@EnnuiL
Copy link
Contributor

EnnuiL commented Jan 25, 2025

While unfortunately I still won't be able to go for The Big Push (it doesn't help that I also want to provide support for Curios on the relevant versions for that full coverage), I think I pulled it off on MC 1.21.4;

Could you test this and see if it works?
EDIT: It turns out testing this properly was more convoluted than expected! Regardless of that, it works:
A Minecraft inventory with modifications from the Accessories mod visible. The player can be seen looking at the only additional slot, the Spyglass slot, where a spyglass item can be seen slotted in. The contents of the usual inventory contain retextured diamonds tools, iron tools (including a crook from Crooked Crooks), wood, golden carrots, and a line of rainbow shulker boxes covering ten columns. The inventory is once again suspiciously larger than usual.

@theDerpu
Copy link
Author

oh hey awesome! sorry I dont use git often didnt get this until now... Is it plausable for this to be added to 1.20.1 as well or is it out of scope? super awesome that you got it going :o

@EnnuiL
Copy link
Contributor

EnnuiL commented Feb 12, 2025

oh hey awesome! sorry I dont use git often didnt get this until now... Is it plausable for this to be added to 1.20.1 as well or is it out of scope? super awesome that you got it going :o

It would be, I just need to take a break for a while until I go messing around with mod stuff once more (so maybe the next MC update); but yeah, this issue will stay open until I get around to adding Accessories (and Curios) support to all active versions so far

@theDerpu
Copy link
Author

Super cool! Hope you have a nice break then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants