Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/numpy_2 #3684

Open
mgraczyk opened this issue Oct 1, 2024 · 2 comments
Open

feat/numpy_2 #3684

mgraczyk opened this issue Oct 1, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mgraczyk
Copy link

mgraczyk commented Oct 1, 2024

Is your feature request related to a problem? Please describe.
Add support for Numpy 2.0

Describe the solution you'd like
Update to onnxruntime 1.19 then change requirements/base.into support Numpy 2, and change any code as necessary to fix changes in types and sorting algorithms (add stable=True if required)

Describe alternatives you've considered
N/A

Additional context
The lack of support in onnxruntime mentioned in the requirements file comment has been resolved:
requirements comment: https://github.com/Unstructured-IO/unstructured/blob/main/requirements/base.in#L14
onnx change: microsoft/onnxruntime#21063

onnxruntime added support for Numpy 2.0 in 1.19

@mgraczyk mgraczyk added the enhancement New feature or request label Oct 1, 2024
@mgraczyk
Copy link
Author

I would submit a PR, but I can't make the dependencies.

$ cd requirements
$ make
# ...
pip._internal.exceptions.DistributionNotFound: No matching distribution found for paddlepaddle==3.0.0b1
make: *** [compile-all-base] Error 1

@MrMegaMango
Copy link

please no longer use numpy 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants
@mgraczyk @MrMegaMango and others