refactor: deprecate v8js and migrate to aux markdown service #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我个人更倾向于 #152 中的纯 PHP 方案？刚刚把 PR 开起来了，之前没有来得及同步到这边。 |
|
也行，不过另外的实现就意味着和上游分道扬镳越来越远了 |
|
我会寻求向上游同步这个修改的可能，比较下来纯 PHP 实现肯定比这种桥接的方案便于维护。 |
|
其实也看生态活跃度，和维护状态。我先关闭这个pr了，看看上游想法 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream removed v8js and uses a aux nodeJS server to render markdown.
This commit synced up partially with the upstream changes.