Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(ci): lint fails #519

Open
3 tasks done
AnonymousWP opened this issue Jun 24, 2024 · 4 comments
Open
3 tasks done

bug(ci): lint fails #519

AnonymousWP opened this issue Jun 24, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@AnonymousWP
Copy link
Member

Describe the bug

With PRs, the linting step is failing: https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/actions/runs/9650187284/job/26615292076#step:6:718.

Expected behavior

I expect the checks to pass.

You have a solution?

No response

Provide logs

CI / GitHub Action logs: https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/actions/runs/9650187284/job/26615292076#step:6:718

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@AnonymousWP AnonymousWP added the bug Something isn't working label Jun 24, 2024
@adhirajsinghchauhan
Copy link
Contributor

Unused var is rarely a useful lint failure. I propose to disable that if possible. Most of the time it's only an annoyance.

However, does anyone know why clippy never reported this failure earlier? It's odd that a linter is flaky.

@AnonymousWP
Copy link
Member Author

Yeah that's odd. Anyway, seems like it's a warning anyway, but still fails. Can you confirm that when I remove scanning for warnings (https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/blob/main/.github/workflows/ci.yml#L41), this should solve the issue?

@adhirajsinghchauhan
Copy link
Contributor

Removing -- -D warnings will still report warnings in logs, but it won't fail the build. This flag only serves to set the error code to a non-zero value.

@AnonymousWP
Copy link
Member Author

Removing -- -D warnings will still report warnings in logs, but it won't fail the build. This flag only serves to set the error code to a non-zero value.

Any idea how to fix this? Isn't that what we want? We want to be informed about warnings, but that shouldn't make the build fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants