Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for Issue #383 - Slime Critter Pushing Player Excessively #404

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

asb9599
Copy link

@asb9599 asb9599 commented Apr 8, 2021

Bugfix for issues #383 and #349: Forum Thread
This issue was caused by the player and Slime colliders overlapping after the player's hit reaction plays, causing it to be pushed backward. The simple fix for this was to simply stop the Slime from moving forward during its attack if it already hit the player. For starters, I created a UnityEvent to be called during successful hit in OnTriggerEnter for the Attack class. Then on the Slime prefab I linked the UnityEvent to call a public method in the SlimeAttackController that simply stops the timer that controls its positional updates during its attack.

This can be tested by getting attacked by a Slime while up against the short rocks near the house in the TestingGround scene, the player is no longer pushed upwards and maintains its position after hit reaction finishes

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2021

CLA assistant check
All committers have signed the CLA.

@amel-unity amel-unity self-assigned this Apr 15, 2021
@amel-unity amel-unity added the bug (important) This needs to be fixed before shipping, but not as a first priority label Apr 15, 2021
Copy link

@RunoLight RunoLight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie dokie

@amel-unity
Copy link
Contributor

Hi @asb9599, thank you for opening this PR. I wanted to mention it here in case you haven't seen the updates on the 2 linked issues:

Thank you

@amel-unity amel-unity added ? Action required: missing information, question to answer, or CLA not signed bug (minor) The game could potentially ship with this bug and removed bug (important) This needs to be fixed before shipping, but not as a first priority labels Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? Action required: missing information, question to answer, or CLA not signed bug (minor) The game could potentially ship with this bug
Projects
None yet
4 participants