Migrate Mono APIs to CoreCLR-compatible APIs for com.unity.postprocessing#8236
Migrate Mono APIs to CoreCLR-compatible APIs for com.unity.postprocessing#8236theo-at-unity merged 3 commits intomasterfrom
Conversation
- RuntimeUtilities.cs: Add conditional compilation (line 1214) - Added using UnityEngine.Assemblies with conditional directive - Maintains backward compatibility with older Unity versions
There was a problem hiding this comment.
I think there may be some confusion. Only files for the com.unity.postprocessing package should be included here. Any files for other packages should be done on the main repo.
Please remove the files which are not part of the com.unity.postprocessing package.
Thanks for the clarification Ben! Will do so :) |
MiroBrodlovaUnityGit
force-pushed
the
fix/remove-mono-api
branch
from
e99e43c to
cc97131
Compare
|
There we go! Only changes to |
MiroBrodlovaUnityGit
changed the title
BenGraterUnity
left a comment
BenGraterUnity
left a comment
There was a problem hiding this comment.
Tested in 6000.5.0a3 Windows/DX12. 👍
|
Thanks for the help Ben! Just wanted to double check, is there something I should do/any jobs I should run to get this PR in a land:able state? Or is it mostly now to sit tight and wait a bit? :) Asking to make sure I do everything I should do! |
|
@MiroBrodlovaUnityGit Please merge |
- Added Unreleased section with fix note for Mono to CoreCLR API migration
- Resolved CHANGELOG.md conflict by keeping both [Unreleased] section with CoreCLR API fix and new [3.5.1] version
|
@theopnv This looks good, please merge this. 👍 |
3 participants
Purpose of PR
This PR replaces all instances of analyzer-highlighted
MonoAPI calls withCoreCLR-compatible API calls for the packagecom.unity.postprocessing, and is part of Epic SCP-1555.Further Context
Monoto usingCoreCLR.JIRA-ticket
Testing
Running the default job-suite. Please share if there are additional steps needed!