Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize ERC721Permit Hashing #239

Closed
saucepoint opened this issue Aug 1, 2024 · 1 comment · Fixed by #260
Closed

Optimize ERC721Permit Hashing #239

saucepoint opened this issue Aug 1, 2024 · 1 comment · Fixed by #260
Labels
posm position manager

Comments

@saucepoint
Copy link
Collaborator

Optimize with assembly

keccak256(abi.encode(PERMIT_TYPEHASH, spender, tokenId, nonce, deadline));

Originally posted by @hensha256 in #210 (comment)
@linear Linear
Copy link

linear bot commented Aug 1, 2024

PROTO-390 Optimize ERC721Permit Hashing

@saucepoint saucepoint added the posm position manager label Aug 1, 2024
@hensha256 hensha256 mentioned this issue Aug 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
posm position manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimise permit hashing Uniswap/v4-periphery
1 participant
@saucepoint