Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Position Manager #15

Closed
hensha256 opened this issue Jun 6, 2023 · 2 comments
Closed

Create Position Manager #15

hensha256 opened this issue Jun 6, 2023 · 2 comments
Assignees

Comments

@hensha256
Copy link
Contributor

hensha256 commented Jun 6, 2023

Much like the V3 NonfungiblePositionManager, we need a position manager for V4 too.

While it could still be an ERC721 like in V3, it would be interesting to explore the use of ERC1155. If 2 positions have:

  • the same pool
  • the same lower tick
  • the same upper tick

They are fungible, and could be minted amounts of the same ERC1155 ID. We could use hash(poolID, tickLower, tickUpper) as token ID, and liquidity as the amount.

@ewilz
Copy link
Member

ewilz commented Jul 3, 2023

Bc of the time component baked into V3 math with fees, it's very difficult to make 1155's fungible per range :((( 1155's may still be worth exploration.

Next PositionManager Implementation should allow:

  • Altering range of entire position without reminting a new position (gas savings for rebalancing)
  • Should not implemenent ERC-721 Enumerable extension (gas savings for mint)
  • More granular storage access (gas savings for loading position data)

@azflin azflin self-assigned this Jul 6, 2023
@saucepoint saucepoint assigned saucepoint and unassigned azflin Feb 23, 2024
@saucepoint
Copy link
Collaborator

#141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants