Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelines that are set to "Read only" should be visible and executable by users #580

Open
yyz1989 opened this issue Apr 18, 2016 · 7 comments
Assignees
Milestone

Comments

@yyz1989
Copy link

yyz1989 commented Apr 18, 2016

Hi, currently pipelines with access rights set to "Read only" can be seen by all users, but they cannot execute the pipelines. The only possible action is "Copy", and users have to use "Copy" to create private pipelines and then modify and execute them. I think the expected outcome is all users can see and also execute pipelines directly, but only creators and admins can modify them.

@yyz1989
Copy link
Author

yyz1989 commented Apr 18, 2016

See screenshot, there is only one action avialable:

screen shot 2016-04-18 at 17 49 21

@tomas-knap
Copy link

Summary: When the pipeline is in public - read only mode, it is correct that others cannot change the pipeline. But it should be possible for others to not only copy the pipeline, but also to run the pipeline

@yyz1989
Copy link
Author

yyz1989 commented May 29, 2016

Moreover, we also need to discuss if a public pipeline started by one user can be seen and controlled by another user

@yyz1989
Copy link
Author

yyz1989 commented Jun 1, 2016

When a pipeline belongs to a user privately, and an admin runs it, the user cannot see it in the monitor. I think the user should not have the permission to cancel it, but should at least be able to see it because he is the owner.

@tomas-knap
Copy link

tomas-knap commented Jul 25, 2016

Moreover, we also need to discuss if a public pipeline started by one user can be seen and controlled by another user

If the pipeline was executed by user A (normal user), it is his execution and user B (normal user) should not be able to control executions of user A.

Currently, if user A creates a pipeline and executes, user B (with admin rights) can see such pipeline execution.

@tomas-knap
Copy link

So a suggest to solve the issue - When the pipeline is in public, read only mode, it should be possible for others to not only copy the pipeline, but also to run the pipeline - then we can discuss what should be adjusted next

@skrchnavy
Copy link

Why not to improve permissions model to be 'unix like' with rwx flags per pipeline?
r=view/copy
w=edit
x=execute/see executions/stop executions

@tomas-knap tomas-knap modified the milestones: Release v2.3.3, Release v2.3.2 Oct 13, 2016
@tomas-knap tomas-knap modified the milestones: Release v3.1, Release v3.X Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants