Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider assert_allclose #3244

Open
dcamron opened this issue Oct 25, 2023 · 0 comments
Open

Consider assert_allclose #3244

dcamron opened this issue Oct 25, 2023 · 0 comments
Labels
Area: Tests Affects tests Type: Maintenance Updates and clean ups (but not wrong)

Comments

@dcamron
Copy link
Member

dcamron commented Oct 25, 2023 •
edited
Loading

What should we add?

In some cases, our decimal precision in assert_almost_equal doesn't capture relative errors with the sensitivity we might expect. We might consider evaluating if the tolerance options in assert_allclose are more appropriate for some/all of our numerical tests.
@dcamron dcamron added Type: Feature New functionality Type: Maintenance Updates and clean ups (but not wrong) Area: Tests Affects tests and removed Type: Feature New functionality labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Tests Affects tests Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcamron