-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vibrato support for Ultrastar Deluxe #861
Comments
This looks like you're playing on Easy or Medium difficulty. They allow you to be off by two or one semitone respectively, and still count that as hitting the right pitch. Notice how the note bars are "thicker" on easier difficulties, indicating that there's a wider range of pitches that are accepted as correct. |
That is not what I am requesting. I am requesting that like the screenshot attached a wave goes over the note bar when a vibrato is done when singing on any difficulty. Thanks so much for the fast reply. |
Can you link a song from usdx.animux.de + the sentence number (select the song, press From what I've read on the internet, vibrato can be really subtle* all the way to what should in the txt be different notes (most noticeable on Hard), and right now I have no idea what kind of vibrato we're looking at. The * in my previous sentence is extremely relevant because my voice has an awesome deviation where if you ask me to sing and hold a G#, I will sing perfectly between G and G# to the point where USDX is literally alternating between detecting G and G# every beat or two. But if it's way more obvious ones like https://4everfreebrony.bandcamp.com/track/the-highest-tower-feat-eilemonty at 00:36 or 00:55, then I can tell from the screenshot that whatever txt that is from, it's not set up correctly. |
If I understood correctly, this is more about having an additional visualization that shows the exact frequency of the singer, in addition to the current one which does not that due to
rather than changing the way anything is scored or similar |
So "basically" we have to see the unsung drawn bar as a hitbox and draw a line for what it's actually detecting, then compute how much of the time that line was inside the hitbox? What I dislike it needing to be additional/an option (or even better: both) because it's only improving the information shown to the player. |
Please, do not create duplicate issues
Actual behaviour
When singing a long note and singing a vibrato the game does not acknowledge it.
Expected behaviour
When singing a long note and singing a vibrato the game displays a wave on the note
Steps to reproduce
Details
Provide some additional information:
The text was updated successfully, but these errors were encountered: