Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vibrato support for Ultrastar Deluxe #861

Open
sam394 opened this issue Jun 26, 2024 · 5 comments
Open

Add Vibrato support for Ultrastar Deluxe #861

sam394 opened this issue Jun 26, 2024 · 5 comments

Comments

@sam394
Copy link

sam394 commented Jun 26, 2024

Please, do not create duplicate issues

Actual behaviour

When singing a long note and singing a vibrato the game does not acknowledge it.

Expected behaviour

When singing a long note and singing a vibrato the game displays a wave on the note
4557632696_51bf3c49b8

Steps to reproduce

  1. Select a song with long notes
  2. Sing a long note with vibrato in voice
  3. Verify the game does not acknowledge and show the wave on the note

Details

Provide some additional information:

  • USDX version:2024.3.0
  • Operating System + version: Windows 11 Home + 23H2
@DeinAlptraum
Copy link
Contributor

This looks like you're playing on Easy or Medium difficulty. They allow you to be off by two or one semitone respectively, and still count that as hitting the right pitch. Notice how the note bars are "thicker" on easier difficulties, indicating that there's a wider range of pitches that are accepted as correct.
If I'm understanding your complaint correctly and you want only "exact" matches, then you should switch the difficulty to Hard

@sam394
Copy link
Author

sam394 commented Jun 28, 2024

That is not what I am requesting. I am requesting that like the screenshot attached a wave goes over the note bar when a vibrato is done when singing on any difficulty. Thanks so much for the fast reply.

@barbeque-squared
Copy link
Member

Can you link a song from usdx.animux.de + the sentence number (select the song, press E, use up/down arrow keys and somewhere in the bottom left it will say something like Sentences 15/54) ?

From what I've read on the internet, vibrato can be really subtle* all the way to what should in the txt be different notes (most noticeable on Hard), and right now I have no idea what kind of vibrato we're looking at. The * in my previous sentence is extremely relevant because my voice has an awesome deviation where if you ask me to sing and hold a G#, I will sing perfectly between G and G# to the point where USDX is literally alternating between detecting G and G# every beat or two.

But if it's way more obvious ones like https://4everfreebrony.bandcamp.com/track/the-highest-tower-feat-eilemonty at 00:36 or 00:55, then I can tell from the screenshot that whatever txt that is from, it's not set up correctly.

@DeinAlptraum
Copy link
Contributor

If I understood correctly, this is more about having an additional visualization that shows the exact frequency of the singer, in addition to the current one which does not that due to

  • only full semitone steps being drawn
  • only full (quarter?) beats being drawn
  • on lower difficulties, the entire thickness of the bar being marked rather than just the sung pitch

rather than changing the way anything is scored or similar

@barbeque-squared
Copy link
Member

So "basically" we have to see the unsung drawn bar as a hitbox and draw a line for what it's actually detecting, then compute how much of the time that line was inside the hitbox?
So as a first start we could just make the "you sung this" bars always behave like they do on Hard (ie they're thin and on Easy you can see how much you're off the center of the note)? Maybe eventually we can upgrade it even more like maybe it draws a line and it computes how much % of the note that line was inside the allowed hitbox.

What I dislike it needing to be additional/an option (or even better: both) because it's only improving the information shown to the player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants