Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 tasks, same manifest filename = cross-contamination #17

Open
goosechaser opened this issue Nov 24, 2014 · 4 comments
Open

2 tasks, same manifest filename = cross-contamination #17

goosechaser opened this issue Nov 24, 2014 · 4 comments

Comments

@goosechaser
Copy link

I'm running 2 buster tasks using different source files but both outputting the manifest file with the same name, although in different directories. There are files from the first task that end up in the second, or vice versa. If the manifest filename is different, then all works fine.

@UltCombo
Copy link
Owner

This is expected behavior, it is listed in the Architecture pros vs cons - https://github.com/UltCombo/gulp-buster#architecture

Right now, the output filename serves as the "manifest id" for the internal cache to work properly. Anything else would seem to overcomplicate this. Feel free to suggest improvements.

@goosechaser
Copy link
Author

My use case: 2 manifests, one for development and one for production environments. Each environment contains a different set of assets.

Perhaps a configuration option to disable that?

@UltCombo
Copy link
Owner

Uhm, I see. This is an issue I've been considering for a while, but never gave it much thought as I'd like to avoid complicating the most common use cases.

As far as I can see, there are 2 options:

  • An workaround in your own code: pass a different filename to gulp-buster, then pipe the manifest file through gulp-rename to set the output name you'd like.
  • A real fix would be to have a manifestId/cacheId option in this plugin to solve your use case without hacks, which defaults to the output filename for back-compat.

@benface
Copy link
Contributor

benface commented Jun 3, 2016

@UltCombo Option 2 sounds perfect. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants