Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some private shared libraries install to incorrect directory #20

Open
allen-ukui opened this issue Dec 24, 2020 · 0 comments
Open

Some private shared libraries install to incorrect directory #20

allen-ukui opened this issue Dec 24, 2020 · 0 comments

Comments

@allen-ukui
Copy link

The only time a binary or shared library in a Debian package should set RPATH or RUNPATH is if it is linked to private shared libraries in the same package. In that case, place those private shared libraries in /usr/lib/package. Libraries used by binaries in other packages should be placed in /lib or /usr/lib as appropriate, with a proper SONAME, in which case RPATH/RUNPATH is unnecessary.

In this project, the follow libraries installed to ${PLUGIN_INSTALL_DIR}, it should must be fixed. The correct directory that target will installed is /usr/lib/.

I think you should use GNUInstallDirs to set it.

install(TARGETS k3baudiometainforenamerplugin DESTINATION ${PLUGIN_INSTALL_DIR} )

install(TARGETS k3baudioprojectcddbplugin DESTINATION ${PLUGIN_INSTALL_DIR})

install(TARGETS k3bsoxencoder kcm_k3bsoxencoder DESTINATION ${PLUGIN_INSTALL_DIR} )

install(TARGETS k3bexternalencoder kcm_k3bexternalencoder DESTINATION ${PLUGIN_INSTALL_DIR})

install(TARGETS k3blameencoder kcm_k3blameencoder DESTINATION ${PLUGIN_INSTALL_DIR})

install(TARGETS k3boggvorbisencoder kcm_k3boggvorbisencoder DESTINATION ${PLUGIN_INSTALL_DIR} )

install(TARGETS k3bffmpegdecoder DESTINATION ${PLUGIN_INSTALL_DIR} )

install(TARGETS k3bflacdecoder DESTINATION ${PLUGIN_INSTALL_DIR})

install(TARGETS k3blibsndfiledecoder DESTINATION ${PLUGIN_INSTALL_DIR})

install(TARGETS k3bmaddecoder DESTINATION ${PLUGIN_INSTALL_DIR} )

install(TARGETS k3bmpcdecoder DESTINATION ${PLUGIN_INSTALL_DIR})

install(TARGETS k3boggvorbisdecoder DESTINATION ${PLUGIN_INSTALL_DIR})

install(TARGETS k3bwavedecoder DESTINATION ${PLUGIN_INSTALL_DIR})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant