V1 of States Endpoint Broken

[krowvin]

Automation Testing for CWMSjs - /states

Testing V1 of the /states endpoint

curl -X 'GET' 'https://water.usace.army.mil/cwms-data/states'

returns

{"message":"Formatting error:No Format for this content-type and data type : (application/json, cwms.cda.data.dto.State)","incidentIdentifier":"8527238373666025493","details":{}}

Version 2 works,

Should we migrate the code to V1 and go ahead and remove versioning on this endpoint so that both return results?

[rma-rripken]

Why/how is V1 even being tried? The end-point is marked JSONv2 which means its in the schema as v2 only. Swagger-ui will only generate v2 requests. Anything that uses some sort of codegen should also be using v2 or the codegen is broken.

There are other existing issues to make default application/json map to latest version but those haven't been started.

[MikeNeilson]

That's probably coming from cwms-data.usace.army.mil since I haven't quite gotten it updated yet.

[rma-rripken]

Thats not it. States is v2 only on cwms-data.usace.army.mil as well.

[MikeNeilson]

Oh ... right, states. Sorry, I got totally confused there. that's a brand new endpoint.

[MikeNeilson]

Oh I see the issue now. EITHER @krowvin needs to change is javascript to explicitly use `application/json;version=2" OR we need to alias that data type to application/json... which we need to do anyways.

[krowvin]

needs to change is javascript to explicitly use `application/json;version=2"

Which I did do in the later example and mentioned V2 works. But out of the gate endpoints imo should return some sort of result.

Anything that uses some sort of codegen should also be using v2 or the codegen is broken.

Also possible

But I presume this will be sorted as mentioned later. Plan to do more testing using the latest changes for CDA against CWMSjs.

[rma-rripken]

But out of the gate endpoints imo should return some sort of result.

I still don't understand the point of this issue. Your test is calling it wrong. And you are getting a result - you are getting an error, which is the right thing for CDA to return with those inputs.

[MikeNeilson]

This probably also overcome by events given we've added the alias system with better defaults.