Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMS-428: case detail accessibility #914

Merged
merged 21 commits into from
Sep 20, 2024

Conversation

fmaddenflx
Copy link
Contributor

@fmaddenflx fmaddenflx commented Sep 16, 2024

Purpose

Fixed non-critical Accessibility Issues

resolved the following issues:

  • Look at H1 with name of page. Page is not titled, Perhaps should be Case Details
  • Correct the Back to case list link. Could we know where the user came from to go back? Could be coming from My Cases, Staff Assignment, or Case Search.
  • Rename Basic Information to Case Details Overview?
  • Rename Audit History (Audit has baggage)
  • Display the division code somewhere
  • fix the space between labels and data.
  • Change History empty state alert (no changes made) should say "No changes have been made to this case."

In regards to the backlink. We looked into various ways to accomplish this and each one opened up a large can of worms causing disorienting effects for the users. It was decided in the end that it would be better to not have a backlink. Backlink removed and all associated code dealing with localstorage and/or broadcast channel removed.

Testing/Validation

Testing is not yet complete.

Definition of Done:

  • Acceptance criteria met - The system meets all acceptance criteria
  • Feature toggles created - Features that are deployed but not released have toggles
  • Design QA passed - All visual UI looks and works the way it’s supposed to
  • Usability validated - Team ensures the working code is easy to use
  • Accessibility tests passed - System passes automated and manual accessibility tests and supports applicable devices
  • Code refactored for clarity - Developers can understand the work simply by reviewing the code
  • Dependency Rule followed - More important code doesn’t directly depend on less important code
  • Development debt eliminated - UX and code aligns to the team’s latest understanding of the domain
  • Source code merged - Code has been merged into the main branch
  • 90% unit test coverage achieved - Automated test coverage tools indicate coverage of >= 90%
  • Code reviewed - Code is reviewed by at least two other team members before being merged
  • Code quality checks passed - Code passes all automated quality checks
  • Security scans passed - Code passes expected scans for vulnerabilities and compliance issues
  • Threat model updated - The threat model incorporates new threats and remediations
  • Build process updated - Automated build process include code supporting the user story
  • Load/performance tests passed - Performance tests include the functionality of the user story
  • Documents are updated - All required documentation is up to date and version controlled
  • Code is deployed - Code is deployed to the highest production like environment

amorrow-flexion and others added 7 commits September 16, 2024 11:25
Jira ticket: CAMS-
Jira ticket: CAMS-428
updated tests accordingly

surface level changed Audit History to Change History

Jira ticket: CAMS-428
resolved the following issues:

* Look at H1 with name of page. Page is not titled, Perhaps should be Case Details
* Correct the Back to case list link. Could we know where the user came from to go back? Could be coming from My Cases, Staff Assignment, or Case Search.
* Rename Basic Information to Case Details Overview?
* Rename Audit History (Audit has baggage)
* Display the division code somewhere
* fix the space between labels and data.
* Change History empty state alert (no changes made) should say "No changes have been made to this case."

Jira ticket: CAMS-428
@fmaddenflx fmaddenflx requested review from a team as code owners September 16, 2024 23:36
Jira ticket: CAMS-428

Co-authored-by: Arthur Morrow <[email protected]>
Co-authored-by: James Brooks <[email protected]>
fmaddenflx and others added 2 commits September 17, 2024 10:57
When clicking back link, the user is directed back to original tab.  Tab
name is updated on login.  If user closes original tab, a new tab is
opened with the same name.

Jira ticket: CAMS-428
…accessibility-fritz-exp

Exp - always take user back to original tab
Jira ticket: CAMS-428

Co-authored-by: Fritz Madden <[email protected]>
Jira ticket: CAMS-428
Jira ticket: CAMS-428

Co-authored-by: Arthur Morrow <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
Jira ticket: CAMS-428
@fmaddenflx fmaddenflx merged commit 13f7435 into main Sep 20, 2024
14 checks passed
@fmaddenflx fmaddenflx deleted the CAMS-428-case-detail-accessibility branch September 20, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants