Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create OTP class based on SMTP SSL #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

R1D3R175
Copy link

Closes #9
This class is meant to be used for mail providers that allow login via SMTP (such as libero.it).

Copy link
Member

@infra-blue infra-blue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mi sembra tutto a posto, stasera controllo sia questo che l'altra pr e mergio

module/otp.py Outdated Show resolved Hide resolved
module/otp.py Outdated Show resolved Hide resolved
@TendTo
Copy link
Member

TendTo commented Nov 14, 2023

If you plan on using sphinx for the documentation, you can avoid repeating the types for each argument/return statement and use the sphinx-autodoc-typehints extension to add them for you.
As long as you use the correct type hint in python (and you really should!), the docstrings go from

def send(self, to: str) -> str:
    """
        Sends a randomly generated OTP to the specified email address.
        Args:
            to (str): The email address of the recipient.
        Returns:
            str: The OTP sent to the specified email address.
    """

# to

def send(self, to: str) -> str:
    """
        Sends a randomly generated OTP to the specified email address.
        Args:
            to: The email address of the recipient.
        Returns:
            The OTP sent to the specified email address.
    """

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a mail system to confirm user identity
3 participants