Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Bonus" headers unique across lessons #168

Open
kelly-sovacool opened this issue Dec 16, 2021 · 0 comments
Open

Make "Bonus" headers unique across lessons #168

kelly-sovacool opened this issue Dec 16, 2021 · 0 comments

Comments

@kelly-sovacool
Copy link
Member

From #166 (comment) by @MrFlick:

The last issue is that all-in-one page (aio) has several duplicate IDs. Sections like "#bonus" are repeated in multiple lessons. So when everything is combined on the same page, those IDs are no longer unique. This means that if you click a later "bonus" link, you are sent to the first bonus section, for example. I'm not sure how important that is but we could make the section names unique across all lessons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant