Skip to content

Commit decd70c

Browse files
TeodorTaushanovilhan007
authored andcommitted
fix(ui5-li-notification): Fix contents if description cannot wrap (#3035)
Fixes: #2920
1 parent 47d3d02 commit decd70c

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

packages/fiori/src/themes/NotificationListItem.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@
5959
display: flex;
6060
flex-direction: column;
6161
flex: 1;
62+
min-width: 0; /* fixes Chrome flex issue */
6263
width: 100%;
6364
padding: 0 1rem 0 0.75rem;
6465
font-family: "72override", var(--sapFontFamily);

packages/fiori/test/pages/NotificationListGroupItem.html

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -226,11 +226,11 @@ <h3>Events on ui5-list level</h3>
226226
<span slot="footnotes">John Doe</span>
227227
<span slot="footnotes">2 Days</span>
228228
<span slot="footnotes">Other stuff</span>
229-
229+
230230
<ui5-notification-action id="acceptBtnInPopover" icon="accept" text="Accept" slot="actions"></ui5-notification-action>
231231
<ui5-notification-action id="rejectBtnInPopover" icon="message-error" text="Reject" slot="actions"></ui5-notification-action>
232232
</ui5-li-notification>
233-
233+
234234
<ui5-li-notification
235235
show-close
236236
show-counter
@@ -239,13 +239,13 @@ <h3>Events on ui5-list level</h3>
239239
>
240240
And with a very long description and long labels of the action buttons - Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent feugiat, turpis vel scelerisque pharetra, tellus odio vehicula dolor, nec elementum lectus turpis at nunc.
241241
<ui5-avatar icon="employee" size="XS" slot="avatar"></ui5-avatar>
242-
242+
243243
<span slot="footnotes">Office Notifications</span>
244244
<span slot="footnotes">3 Days</span>
245-
245+
246246
<ui5-notification-action icon="accept" text="Accept" slot="actions"></ui5-notification-action>
247247
</ui5-li-notification>
248-
248+
249249
</ui5-li-notification-group>
250250

251251
<ui5-li-notification-group
@@ -260,23 +260,23 @@ <h3>Events on ui5-list level</h3>
260260
>
261261
Short description
262262
<ui5-avatar initials="JS" size="XS" slot="avatar"></ui5-avatar>
263-
263+
264264
<span slot="footnotes">Patricia Clarck</span>
265265
<span slot="footnotes">3 Days</span>
266-
266+
267267
<ui5-notification-action icon="accept" text="Accept All Requested Information" slot="actions"></ui5-notification-action>
268268
<ui5-notification-action icon="message-error" text="Reject All Requested Information" slot="actions"></ui5-notification-action>
269269
</ui5-li-notification>
270-
270+
271271
<ui5-li-notification
272272
heading="New order (#2523)"
273273
priority="Low"
274274
>
275275
<div>. With a very long description - Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent feugiat, turpis vel scelerisque pharetra, tellus odio vehicula dolor, nec elementum lectus turpis at nunc.</div>
276-
276+
277277
<span slot="footnotes">John SMith</span>
278278
<span slot="footnotes">3 Days</span>
279-
279+
280280
<ui5-notification-action icon="message-error" text="Reject" slot="actions"></ui5-notification-action>
281281
</ui5-li-notification>
282282
</ui5-li-notification-group>
@@ -326,7 +326,7 @@ <h3>Events on ui5-list level</h3>
326326
}, 2000);
327327
});
328328

329-
329+
330330

331331
shellbar.addEventListener("ui5-notificationsClick", function(event) {
332332
event.preventDefault();

0 commit comments

Comments
 (0)