Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text annotation and comments #2

Closed
raquelalegre opened this issue Dec 1, 2020 · 3 comments
Closed

Text annotation and comments #2

raquelalegre opened this issue Dec 1, 2020 · 3 comments

Comments

@raquelalegre
Copy link
Contributor

raquelalegre commented Dec 1, 2020

Text commentary linked to:

  • any object field
  • particular substrings in text fields (must be in HTML) (e.g. comments, biography, original texts, ...)
@raquelalegre raquelalegre self-assigned this Dec 1, 2020
@raquelalegre raquelalegre changed the title Create SVG files for non-standard symbols that are not included in the alphabetum font Text annotation and comments Dec 1, 2020
@raquelalegre
Copy link
Contributor Author

Peter says:

Mechanism to allow comments to be added to any object field and also to be able to insert links from longer text fields (e.g. biography) to show the comments on hover.

Complication might arise where comments overlap but should be okay as long as they don't completely overlap one another.

Involves a reworking of the existing comment system which allowed for comments on database objects rather than on named object fields.

@raquelalegre
Copy link
Contributor Author

We might be Ok just using hypothes.is, which would save us quite a lot of time. We need to:

  • Let History play with the tool and see if they're OK with it. First they will need access to the VM...
  • Ask ISD if there's a UCL instance of it - Pervin is going to ask DigiEd about this.
  • Make sure we comply with Hypothes.is licensing.
  • Arrange meeting with Amish and Emma about using this tool for the duration of the project. The HDL will need to be updated.

Users want to be able to use non-standard characters in the comments text. This is problematic as Hypothes.is doesn't support this font. Peter has tried to create a CSS class to show these characters when using the Hypothes.is browser extension in the website, but it's proven to be tricky. He needs to investigate further. We need to ask Valentina if they are ok with this as a nice-to-have for after the MVP.

@raquelalegre
Copy link
Contributor Author

Mostly done, leftover tasks in #21 and #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant